Implement mtom xop file upload #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpinter
approved these changes
Feb 20, 2025
| test('MTOM request', async () => { | ||
| const fileName = 'plain-data.txt' | ||
|
|
||
| console.log('start reading') |
There was a problem hiding this comment.
you may not want/need this in the commited tests ? but if you prefer keeping the logs then ok
There was a problem hiding this comment.
It was there before with the original file, so i only kept the notation. But now after thinking about it, I probably don't want it there, since the test files are very small anyway.
mpinter
added
pr: fix & ship 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MTOM file upload endpoint to avoid encoding file content into base64 and then having the server parse it as a part of XML causing performance issues with files larger than 5MB.