-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#277 Use i18next-parser
#289
Conversation
ea88db4
to
f320113
Compare
+ add missing translations
f320113
to
46841be
Compare
next/package.json
Outdated
"prettier": "prettier --write ." | ||
"prettier": "prettier --write .", | ||
"parse-translations": "i18next", | ||
"update-i18next": "yarn add next-i18next@latest react-i18next@latest i18next@latest -E && yarn add eslint-plugin-i18next@latest i18next-parser@latest --dev --exact" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why yarn when npm is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 good job!
Test build pipeline info 🚀 🔜 next |
Description
Use
i18next-parser
as in other projects.Cleanup translations files and config.
Testing
The site should run correctly.
When browsing the website, all text should be correctly translated, no translation key should be visible (e.g.
common.buyAsGift
)Notes
i18next-parser
need node v18, so this PR is blocked until #288 is merged.