Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#277 Use i18next-parser #289

Merged
merged 9 commits into from
Mar 10, 2025
Merged

Conversation

radoslavzeman
Copy link
Contributor

@radoslavzeman radoslavzeman commented Mar 6, 2025

Description

Use i18next-parser as in other projects.
Cleanup translations files and config.

Testing

The site should run correctly.
When browsing the website, all text should be correctly translated, no translation key should be visible (e.g. common.buyAsGift)

Notes

i18next-parser need node v18, so this PR is blocked until #288 is merged.

@radoslavzeman radoslavzeman linked an issue Mar 6, 2025 that may be closed by this pull request
@radoslavzeman radoslavzeman force-pushed the 277-techdebt-use-i18next-parser branch from ea88db4 to f320113 Compare March 6, 2025 08:27
@radoslavzeman radoslavzeman changed the title 277 techdebt use i18next parser #277 Use i18next-parser Mar 6, 2025
@radoslavzeman radoslavzeman marked this pull request as ready for review March 6, 2025 08:35
@radoslavzeman radoslavzeman added pr: blocked 🚧 Waiting for work outside of this PR to be done first pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review labels Mar 6, 2025
@radoslavzeman radoslavzeman requested a review from Ty-ci March 6, 2025 08:38
@radoslavzeman radoslavzeman removed the pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review label Mar 6, 2025
@radoslavzeman radoslavzeman force-pushed the 277-techdebt-use-i18next-parser branch from f320113 to 46841be Compare March 7, 2025 13:44
@radoslavzeman radoslavzeman removed the pr: blocked 🚧 Waiting for work outside of this PR to be done first label Mar 7, 2025
"prettier": "prettier --write ."
"prettier": "prettier --write .",
"parse-translations": "i18next",
"update-i18next": "yarn add next-i18next@latest react-i18next@latest i18next@latest -E && yarn add eslint-plugin-i18next@latest i18next-parser@latest --dev --exact"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why yarn when npm is used?

Copy link

@Ty-ci Ty-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 good job!

@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Mar 9, 2025
@radoslavzeman radoslavzeman merged commit ec3cd65 into master Mar 10, 2025
1 check passed
@radoslavzeman radoslavzeman deleted the 277-techdebt-use-i18next-parser branch March 10, 2025 08:50
Copy link

github-actions bot commented Mar 10, 2025

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: false

➡️ Changes in next: true

We are going to build 🚢

🔜 next

🥳 Bratiska-cli successfully built an image from path: next/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TechDebt: Use i18next-parser
2 participants