Test improvements #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
force-pushed
the
test-improvements
branch
2 times, most recently
from
adbaca4
to
4f60c80
Compare
antonok-edm
force-pushed
the
test-improvements
branch
from
4f60c80
to
91d26a2
Compare
antonok-edm
force-pushed
the
test-improvements
branch
2 times, most recently
from
648df82
to
556fcc4
Compare
antonok-edm
force-pushed
the
test-improvements
branch
from
556fcc4
to
51c3737
Compare
note that "relative selectors"[0] will be canonicalized by adblock-rust at parsing time to have an explicit leading descendant combinator rather than an implicit one. [0] - https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_selectors/Selector_structure#relative_selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a couple of minor changes I made to make these easier to test manually (i.e. without Playwright)