Restructure Token Issuer #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change token issuer function to use goroutines and a waitgroup to manage asynchronous processing instead of immediate commits.
sadasant
reviewed
Feb 14, 2022
| @@ -107,6 +107,8 @@ func (c *Server) redeemTokenV2(issuer *Issuer, preimage *crypto.TokenPreimage, p | |||
| } | |||
|
|
|||
| input := &dynamodb.PutItemInput{ | |||
| // @ME emit different error messages depending on whether the ID is the same and the data is different or the ID is the same AND the data is the same. | |||
| // Batch persistence if possible | |||
sadasant
reviewed
Feb 14, 2022
| for _, topicMapping := range topicMappings { | ||
| if msg.Topic == topicMapping.Topic { | ||
| go func( |
There was a problem hiding this comment.
I’m curious! Is there any disadvantage on keeping this goroutine here?
sadasant
reviewed
Feb 14, 2022
| Issuer_public_key: "", | ||
| Status: ERROR, | ||
| Associated_data: request.Associated_data, | ||
| } |
There was a problem hiding this comment.
Final question, final question! I won’t bother more 😆
Why sending a result with an error and not an error to the error channel?
Given that all of the tokens will fail.
(I am missing so much context… This is just out of curiosity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change token issuer function to use goroutines and a waitgroup to manage
asynchronous processing instead of immediate commits.