Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR121] - New tab button (+) is misaligned on upgrade from C120 -> C121 and in new install as well #35300

Closed
MadhaviSeelam opened this issue Jan 12, 2024 · 6 comments · Fixed by brave/brave-core#21584
Assignees
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

Description

Found while testing #35281. This issue is not present in CR 120 (Current release 1.61.116 Chromium: 120.0.6099.217 or Latest nightly 1.63.113 Chromium: 120.0.6099.217. It is shown when upgraded from CR 120 ->CR 121. Fresh Install from CR121 nightly builds have no issues.

Steps to Reproduce

  1. Install 1.63.113 Chromium: 120.0.6099.217
  2. launch Brave
  3. upgrade to 1.63.110 Chromium: 121.0.6167.57 via brave://settings/help
  4. open a new tab (`+)

Actual result:

(+) is misaligned.

example example
image image

Expected result:

parity with [CR120]

image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.63.110 Chromium: 121.0.6167.57 (Official Build) nightly (64-bit)
-- | --
Revision | f7a7c2ee42626f5a1310c9bd6789d0438e78ca6e
OS | Windows 11 Version 22H2 (Build 22621.3007)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@mkarolin @rebron
cc: @brave/qa-team

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 12, 2024
@rebron
Copy link
Collaborator

rebron commented Jan 12, 2024

cc: @zenparsing

@MadhaviSeelam MadhaviSeelam changed the title [CR121] - New tab button (+) is misaligned on upgrade from C120 -> C121 [CR121] - New tab button (+) is misaligned on upgrade from C120 -> C121 and in new install as well Jan 12, 2024
@simonhong simonhong self-assigned this Jan 16, 2024
@simonhong
Copy link
Member

Fixing now.

@mowny
Copy link

mowny commented Jan 16, 2024

While you're at it, is it intentional that there is so much space between the + and the tab dropdown?
image
And is it normal that there is no overflow indication? If I open even more tabs, they get hidden "behind" the + and I can only get to them by ctrl-tab or the dropdown. That wasted space could display at least 4 more tabs ;)

@kjozwiak
Copy link
Member

Labelling as QA/Blocked as this also needs to be uplifted into 1.62.x which will happen once brave/brave-core#21593 has been uplifted/merged into 1.62.x.

@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (64-bit)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | Windows 10 Version 22H2 (Build 19045.3930)
  • Confirmed that the new tab + is aligned correctly in both clean and upgraded profiles.

Clean profile

Regular window Private window TOR window
image image image

Upgrade profile

1.61.120 1.62.149
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants