Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed new tab button's plus icon is mis-aligned with horizontal tab #21584

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 16, 2024

Resolves brave/brave-browser#35300

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong merged commit 1728f72 into master Jan 17, 2024
19 checks passed
@simonhong simonhong deleted the fix_new_tab_button_plus_misaligned branch January 17, 2024 23:31
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Jan 17, 2024
mkarolin pushed a commit that referenced this pull request Jan 17, 2024
Fixed new tab button's plus icon is mis-aligned with horizontal tab
@zenparsing
Copy link
Collaborator

@simonhong @mkarolin Does this need uplift into Beta (1.63)?

@mkarolin
Copy link
Collaborator

Thanks @zenparsing, I created the uplift.

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.5 Chromium: 121.0.6167.75 (Official Build) nightly (64-bit)
-- | --
Revision | 2bf3fedfbbe00d5306677ee5f480580a4c401018
OS | Windows 11 Version 23H2 (Build 22631.3007)

Using the STR/Examples from brave/brave-browser#35300 (comment), ensured that the New Tab + button is correcting being aligned as per the following:

Normal Mode Private Mode Tor Mode Guest Mode
fixed fixed2 fixed3 fixed4

kjozwiak pushed a commit that referenced this pull request Jan 19, 2024
kjozwiak pushed a commit that referenced this pull request Jan 20, 2024
* Merge pull request #21134 from brave/cr121

Upgrade from Chromium 120 to Chromium 121.

* Remove the assert for patch_ffmpeg.py (#21184)

* Merge pull request #21539 from brave/ffmpeg-dynamic-alloc

Use dynamic allocation for ffmpeg fft tables on Windows.

* Merge pull request #21585 from brave/issues/35318

Remove dynamic allocation of ffmpeg ff_tx tables.

* Disables a flaky upstream browser test.

* Merge pull request #21584 from brave/fix_new_tab_button_plus_misaligned

Fixed new tab button's plus icon is mis-aligned with horizontal tab

* Merge pull request #21600 from brave/121.0.6167.75_master

Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75.

* Merge pull request #21628 from brave/maxk-disable-reading-mode

Hides `Open in Reading Mode` context menu item.

* [Uplift 1.62.x] AI chat issues cr121 1.62.x (#21629)

* aichat: input is growable (#21124)

* aichat: scroll is interruptable (#21235)

* aichat: model maker text shouldnt look like a link (#21220)

* aichat: code formatting (#21342)

* make claude output formatted code (#21599)

---------

Co-authored-by: Mikhail <[email protected]>
Co-authored-by: Aleksey Khoroshilov <[email protected]>
Co-authored-by: Simon Hong <[email protected]>
Co-authored-by: taher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CR121] - New tab button (+) is misaligned on upgrade from C120 -> C121 and in new install as well
4 participants