Skip to content

Commit

Permalink
Fix failure calling json function over cxxbridge
Browse files Browse the repository at this point in the history
It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
  • Loading branch information
cdesouza-chromium committed Oct 9, 2024
1 parent 093e733 commit 6a076d5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion browser/sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,10 @@ if (is_win && is_official_build) {
"//chrome/browser/google/switches.h",
]

brave_chrome_browser_deps += [ "//google_update" ]
brave_chrome_browser_deps += [
"//brave/components/brave_adaptive_captcha",
"//google_update",
]
}

brave_chrome_browser_public_deps = [
Expand Down

0 comments on commit 6a076d5

Please sign in to comment.