Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled diagnostic reporting by default #16208

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Enabled diagnostic reporting by default #16208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions components/brave_welcome_ui/components/help-improve/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ function InputCheckbox (props: InputCheckboxProps) {
}

function HelpImprove () {
const [isP3AEnabled, setP3AEnabled] = React.useState(false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this old version was wrong because it should be true for nightly and beta, but the new version is also implemented incorrectly. If we want to default to true, we should change the default pref value, not the UI

const [isMetricsReportingEnabled, setMetricsReportingEnabled] = React.useState(true)
const [isP3AEnabled, setP3AEnabled] = React.useState(true)

const handleP3AChange = () => {
setP3AEnabled(!isP3AEnabled)
Expand Down Expand Up @@ -69,16 +69,16 @@ function HelpImprove () {
</div>
<S.Grid>
<div className="list">
<InputCheckbox
id="p3a"
onChange={handleP3AChange}
isChecked={isP3AEnabled}
labelText={getLocale('braveWelcomeSendReportsLabel')}
/>
<InputCheckbox
id="metrics"
onChange={handleMetricsReportingChange}
isChecked={isMetricsReportingEnabled}
labelText={getLocale('braveWelcomeSendReportsLabel')}
/>
<InputCheckbox
id="p3a"
onChange={handleP3AChange}
isChecked={isP3AEnabled}
labelText={getLocale('braveWelcomeSendInsightsLabel')}
/>
</div>
Expand Down