Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added header to reading list panel #20200

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Added header to reading list panel #20200

merged 3 commits into from
Sep 19, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 18, 2023 •
edited
Loading

fix brave/brave-browser#32953

Reading list header includes its icon & title.

Screenshot 2023-09-18 at 11 02 22 AM

image

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue.

@simonhong simonhong self-assigned this Sep 18, 2023
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Sep 18, 2023
@simonhong
Copy link
Member Author

simonhong commented Sep 18, 2023 •
edited
Loading

--leo-color-container-background is set for header's background color.
However, we still use upstream's reading list webui. So both background colors are slightly different.
We can see it from above screen shot.
@rebron @minkyeongshin Should we go with our colors like above screenshot till reading list webui is updated?
Or should apply same bg color to header area till we have our reading list webui?

Update => To align with webui's bg color, same color is applied to header.

@simonhong
Copy link
Member Author

simonhong commented Sep 18, 2023 •
edited
Loading

Upstream test case(ExtensionSidePanelBrowserTest.WindowCloseCalledWhenLoading) is failed. checking.. => Fixed

@simonhong simonhong marked this pull request as ready for review September 18, 2023 11:05
@simonhong simonhong requested review from a team as code owners September 18, 2023 11:05
sangwoo108
sangwoo108 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

browser/ui/views/side_panel/brave_read_later_side_panel_view.cc Outdated Show resolved Hide resolved
browser/ui/color/brave_color_id.h Outdated Show resolved Hide resolved
@simonhong
Added header to reading list panel
5e2fa93 
fix brave/brave-browser#32953

Reading list header includes its icon & title.
@simonhong
Fixed upstream browser test failure
c385a05 
fixed ExtensionSidePanelBrowserTest.WindowCloseCalledWhenLoading.
This test assumes reading list's content doesn't becomes available
immediately right after calling SidePanelCoordinator::Show(reading_list).
@simonhong
Changed header background color to align with panel's background
a1357e3
@simonhong
Copy link
Member Author

@sangwoo108 Updated. Thanks!

@simonhong simonhong mentioned this pull request Sep 19, 2023
Merged
25 tasks
goodov
goodov approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src lgtm

mkarolin
mkarolin approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@simonhong simonhong merged commit d07e6ba into master Sep 19, 2023
15 checks passed
@simonhong simonhong deleted the reading_list_panel_header branch September 19, 2023 22:40
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangwoo108 sangwoo108 sangwoo108 approved these changes

@goodov goodov goodov approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@simonhong simonhong

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging this pull request may close these issues.

Add title to Reading list side panel
4 participants
@simonhong @sangwoo108 @goodov @mkarolin