Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] remove redirect for filter settings #20212

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#33091

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

We are removing redirect to new filter list settings when they type brave://adblock in url bar. It will display webpage for filters just like desktop

@tapanmodh tapanmodh added this to the 1.60.x - Nightly milestone Sep 19, 2023
@tapanmodh tapanmodh self-assigned this Sep 19, 2023
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapanmodh tapanmodh merged commit 1eb3ec1 into master Sep 20, 2023
17 checks passed
@tapanmodh tapanmodh deleted the remove_redirect_filter_settings_android branch September 20, 2023 05:01
brave-builds added a commit that referenced this pull request Sep 20, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.60.56 Chromium: 117.0.5938.92 (Official Build) canary (64-bit)
--- | ---
Revision | 3b7f9ca8094bbdada8e04aa8531f4bd9becbc25b
OS | Android 14; Build/UPB5.230623.009; 34; REL

Using the STR/Cases outlined via #20212 (comment) and the information from brave/brave-browser#33091, ensured the following:

  • ensured that Content Filtering is visible via Settings -> Brave Shields & privacy -> Content Filtering
  • ensured that visiting brave://adblock doesn't redirect users to Content Filtering under Settings
  • ensured that changes using Content Filtering under Settings are also being displayed under brave://adblock
  • ensured that changes using brave://adblock are also visible via Content Filtering under Settings
Example Example Example
Screenshot_20230925-161621 Screenshot_20230925-161628 Screenshot_20230925-171843

kjozwiak pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Remove redirection to brave://adblock
4 participants