Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced chrome dark logo with channel product logo from settings drawer menu #20215

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 19, 2023

fix brave/brave-browser#31355

Screenshot from 2023-09-20 12-37-15

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Sep 19, 2023
@simonhong
Copy link
Member Author

@rebron this looks fine?

@rebron
Copy link
Collaborator

rebron commented Sep 19, 2023

@rebron this looks fine?

Should we use the Gear icon for Settings instead?
cc: @aguscruiz

@aguscruiz
Copy link
Collaborator

@simonhong can you use the regular Brave logo in dark mode too?
Not that outline one, but the one you used here:

image

@simonhong
Copy link
Member Author

@simonhong can you use the regular Brave logo in dark mode too? Not that outline one, but the one you used here:

Ok, I'll try to put per-channel brave icon there.

@simonhong simonhong changed the title Replaced chrome_dark_logo.svg with ours Replaced chrome dark logo with channel product logo from settings drawer menu Sep 20, 2023
@simonhong simonhong marked this pull request as ready for review September 20, 2023 06:05
@simonhong simonhong requested a review from a team as a code owner September 20, 2023 06:05
@mkarolin
Copy link
Collaborator

@simonhong, can't we just copy our own svg over the upstream one in brave/build/commands/lib/util.js updateBranding?

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonhong in your opinion, is this patch better than overwriting the file from util.js | updateBranding?

@simonhong simonhong removed the request for review from a team September 21, 2023 00:32
@simonhong
Copy link
Member Author

@mkarolin @petemill Oh, right. we also could copy per-channel files before build. Done :)

@simonhong simonhong merged commit 2b0e8c4 into master Sep 21, 2023
15 checks passed
@simonhong simonhong deleted the replace_chrome_dark_logo branch September 21, 2023 14:17
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 21, 2023
brave-builds added a commit that referenced this pull request Sep 26, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.60.59 Chromium: 117.0.5938.92 (Official Build) nightly (64-bit)
-- | --
Revision | a701506b269c40f7d8ad52ecf7dfaae15723ec94
OS | Windows 11 Version 22H2 (Build 22621.2283)

Using the STR/Cases outlined via brave/brave-browser#31355 (comment), ensured that the Chrome icon wasn't appearing via brave://extensions & brave://settings as per the following:

Case #1

Example Example
case1Light case1Dark

Case #2

Example Example
case2Light case2Dark

kjozwiak pushed a commit that referenced this pull request Sep 27, 2023
…wer menu (uplift to 1.59.x) (#20290)

Uplift of #20215 (squashed) to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome logo is shown in Dark mode in the brave://settings page in 1.55.17
8 participants