Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #20227

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix build #20227

merged 1 commit into from
Sep 20, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Sep 20, 2023

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

* The file was removed
@sangwoo108 sangwoo108 marked this pull request as ready for review September 20, 2023 02:13
@sangwoo108 sangwoo108 enabled auto-merge (squash) September 20, 2023 02:15
Copy link
Collaborator

@DJAndries DJAndries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@sangwoo108 sangwoo108 merged commit 9a55916 into master Sep 20, 2023
18 checks passed
@sangwoo108 sangwoo108 deleted the sko/build-fix branch September 20, 2023 05:26
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 20, 2023
atuchin-m added a commit that referenced this pull request Oct 7, 2023
This reverts commit 9a55916.
@atuchin-m atuchin-m mentioned this pull request Oct 7, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants