Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed automated labeling #21433

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Fixed automated labeling #21433

merged 3 commits into from
Dec 20, 2023

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Dec 20, 2023

Resolves #21342 (comment)

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik requested a review from a team as a code owner December 20, 2023 17:05
@wknapik wknapik added the CI/skip Do not run CI builds (except noplatform) label Dec 20, 2023
@wknapik wknapik requested a review from a team as a code owner December 20, 2023 17:06
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Dec 20, 2023
@github-actions github-actions bot removed the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Dec 20, 2023
@wknapik wknapik merged commit fc38f9f into master Dec 20, 2023
7 of 17 checks passed
@wknapik wknapik deleted the wknapik-fix-labeling-action branch December 20, 2023 17:09
@github-actions github-actions bot added this to the 1.63.x - Nightly milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants