Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes asserts on Brave News via accessing current Tab from multiple threads (uplift to 1.62.x) #21691

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fixes asserts on Brave News via accessing current Tab from multiple threads (uplift to 1.62.x) #21691

merged 1 commit into from
Jan 22, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 22, 2024 •
edited by kjozwiak
Loading

Uplift of #21679
Resolves brave/brave-browser#35490

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 22, 2024 19:24
@brave-builds brave-builds added this to the 1.62.x - Release milestone Jan 22, 2024
@brave-builds brave-builds self-assigned this Jan 22, 2024
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Jan 22, 2024
kjozwiak
kjozwiak approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍

@kjozwiak kjozwiak merged commit 43d7f38 into 1.62.x Jan 22, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr21679_android_news_asserts_1.62.x branch January 22, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @SergeyZhukovsky