Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibox changes (location bar height, inkdrop color, icon changes) (uplift to 1.62.x) #21761

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 26, 2024

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong simonhong self-assigned this Jan 26, 2024
@simonhong simonhong requested a review from a team as a code owner January 26, 2024 01:45
@simonhong
Copy link
Member Author

simonhong commented Jan 26, 2024

Note: this uplift request is combination of other 1.63.x uplift PRs(#21740 and #21724)

@kjozwiak kjozwiak added this to the 1.62.x - Release #3 milestone Jan 29, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the above PR(s) on Nightly using 1.64.x as per #21721 (comment), #21729 (comment) & #21722 (comment).

@kjozwiak kjozwiak merged commit bcdd114 into 1.62.x Jan 29, 2024
15 checks passed
@kjozwiak kjozwiak deleted the apply_omnibox_changes_1.62.x branch January 29, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants