Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS griffin support - 1.62.x #21803

Merged
merged 2 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/commands/lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,6 @@ Config.prototype.buildArgs = function () {
delete args.webcompat_report_api_endpoint
delete args.use_blink_v8_binding_new_idl_interface
delete args.v8_enable_verify_heap
delete args.brave_variations_server_url
delete args.enable_dangling_raw_ptr_checks
}

Expand Down

This file was deleted.

This file was deleted.

2 changes: 2 additions & 0 deletions ios/app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ source_set("app") {
"//brave/components/p3a:buildflags",
"//brave/components/skus/browser",
"//brave/components/update_client:buildflags",
"//brave/components/variations:constants",
"//brave/ios/app/resources",
"//brave/ios/browser",
"//brave/ios/browser/api/ads",
Expand Down Expand Up @@ -65,6 +66,7 @@ source_set("app") {
"//components/send_tab_to_self",
"//components/sync/base",
"//components/sync/service",
"//components/variations",
"//ios/chrome/app:app_internal",
"//ios/chrome/app:tests_fake_hook",
"//ios/chrome/app/startup:startup",
Expand Down
9 changes: 5 additions & 4 deletions ios/app/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,20 @@ include_rules = [
"+ios/chrome/common",
"+brave/ios/app",
"+brave/ios/browser",
"+components/browser_sync",
"+components/component_updater/component_updater_paths.h",
"+components/component_updater/component_updater_service.h",
"+components/component_updater/component_updater_switches.h",
"+components/component_updater/installer_policies",
"+components/prefs",
"+components/sync/service",
"+components/sync/base",
"+components/browser_sync",
"+components/history/core/browser",
"+components/keyed_service/core",
"+components/prefs",
"+components/password_manager/core",
"+components/safe_browsing/core/common/safe_browsing_prefs.h",
"+components/send_tab_to_self",
"+components/sync/base",
"+components/sync/service",
"+components/variations/variations_switches.h",
"+ios/public/provider/chrome/browser/chrome_browser_provider.h",
"+ios/public/provider/chrome/browser/overrides/overrides_api.h",
"+ios/public/provider/chrome/browser/ui_utils/ui_utils_api.h",
Expand Down
16 changes: 16 additions & 0 deletions ios/app/brave_main_delegate.mm
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@
#include "brave/components/brave_component_updater/browser/switches.h"
#include "brave/components/brave_sync/buildflags.h"
#include "brave/components/update_client/buildflags.h"
#include "brave/components/variations/buildflags.h"
#include "components/browser_sync/browser_sync_switches.h"
#include "components/component_updater/component_updater_switches.h"
#include "components/sync/base/command_line_switches.h"
#include "components/sync/base/model_type.h"
#include "components/variations/variations_switches.h"
#include "ios/chrome/browser/flags/chrome_switches.h"

#if !defined(__has_feature) || !__has_feature(objc_arc)
Expand Down Expand Up @@ -70,6 +72,20 @@ @implementation BundleLookupClass
BUILDFLAG(BRAVE_SYNC_ENDPOINT));
}

// Brave variations
if (!command_line->HasSwitch(variations::switches::kVariationsServerURL)) {
command_line->AppendSwitchASCII(variations::switches::kVariationsServerURL,
BUILDFLAG(BRAVE_VARIATIONS_SERVER_URL));

// Insecure fall-back for variations is set to the same (secure) URL. This
// is done so that if VariationsService tries to fall back to insecure url
// the check for kHttpScheme in VariationsService::MaybeRetryOverHTTP would
// prevent it from doing so as we don't want to use an insecure fall-back.
command_line->AppendSwitchASCII(
variations::switches::kVariationsInsecureServerURL,
BUILDFLAG(BRAVE_VARIATIONS_SERVER_URL));
}

if (!command_line->HasSwitch(switches::kVModule)) {
command_line->AppendSwitchASCII(switches::kVModule, "*/brave/*=0");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class BraveApplicationContextImpl : public ApplicationContextImpl {

// ApplicationContextImpl
ukm::UkmRecorder* GetUkmRecorder() override;
BrowserPolicyConnectorIOS* GetBrowserPolicyConnector() override;
gcm::GCMDriver* GetGCMDriver() override;

// BraveApplicationContextImpl
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@
return nullptr;
}

BrowserPolicyConnectorIOS*
BraveApplicationContextImpl::GetBrowserPolicyConnector() {
return nullptr;
}

gcm::GCMDriver* BraveApplicationContextImpl::GetGCMDriver() {
return nullptr;
}
Expand Down
Loading