Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(privacy): Update Shred behaviour to clear all cache data #25744

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

StephenHeaps
Copy link
Collaborator

  • When using shred, clear all cache data. Wrapped in a feature flag so we can disable via Griffin.

Resolves brave/brave-browser#41095

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable Shred (#brave-shred) & Shred Cache Data (#brave-shred-cache-data) feature flags, then restart the app.
  2. Visit a site which stores 3rd-party cache (this can be checked in Settings -> Shields & Privacy -> Manage Website Data).
    • Ex. Visitinghttps://google.ca will show data from google.ca, gstatic.com, and google.com.
  3. Visit Settings -> Shields & Privacy -> Manage Website Data to confirm there are entries with just Cache listed in the subtitle/description.
  4. Tap & hold on the tab tray icon & tap 'Shred Site Data'.
Shred.Cache.Data.mp4

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 1, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 1, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner October 1, 2024 14:53
@StephenHeaps StephenHeaps merged commit ec4d271 into master Oct 4, 2024
17 checks passed
@StephenHeaps StephenHeaps deleted the privacy/ios-shred-all-caches branch October 4, 2024 18:05
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 4, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.63

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 9, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.72 (75)

Using Test Plan in #25744 (comment)

Flags: #brave-shred, #brave-shred-cache-data

  • Ensured all website data is deleted when Shredding using Shred Site Data in the tab bar icon.
  • Ensured all website data is deleted when using Auto-Shred per site and globally (~30 secs delay).
  • Ensured that favicon cache is removed from History.
example example example example example example
IMG_7669 IMG_7670 IMG_7671 IMG_7672 IMG_7673 IMG_7676

kjozwiak pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all data stored when visiting a site is deleted when shredding the site
4 participants