Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Update remove asset logic #25805

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix(wallet): Update remove asset logic #25805

merged 3 commits into from
Oct 4, 2024

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Oct 3, 2024

Resolves brave/brave-browser#41357

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Wallet
  2. make sure you have some user assets both fungible or non-fungible
  3. go to Edit User Assets Screen
  4. Observe only NFTs and custom tokens are removable by swipe to left. Other tokens are not removable

Note: There is an crash happens when you actually delete a token. This is an known issue and it is being addressed in this PR

@nuo-xu nuo-xu requested a review from a team as a code owner October 3, 2024 21:00
@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 3, 2024
@StephenHeaps StephenHeaps changed the title fix(wallet): Make only NFTs are removable fix(wallet): Update remove asset logic Oct 4, 2024
@nuo-xu nuo-xu merged commit ccabc90 into master Oct 4, 2024
17 checks passed
@nuo-xu nuo-xu deleted the bugfix/41357 branch October 4, 2024 18:54
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 4, 2024
brave-builds added a commit that referenced this pull request Oct 4, 2024
brave-builds added a commit that referenced this pull request Oct 4, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.63

@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2024

Verification passed on iPhone 13 with iOS 18 running 1.72 (66)

  • Verified steps from PR
  • Verified only NFT's have swipe to delete option
  • Encountered the crash when actually deleting it which is a known issue
NFT.crash.MP4

kjozwiak pushed a commit that referenced this pull request Oct 8, 2024
kjozwiak pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wallet/iOS] User Assets are deletable
4 participants