Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI Chat] Applies pre-wrap to user messages #25823

Closed
wants to merge 1 commit into from

Conversation

jonathansampson
Copy link
Contributor

@jonathansampson jonathansampson commented Oct 4, 2024

Newline characters are being preserved, but not displayed. This change permits the newline characters to be impactful on the end-result, while still allowing natural wrapping of content. The change is applied exclusively to turn entries associated with user input.

Resolves brave/brave-browser#41409

Left: Currently night, where newlines are not respected.
Right: Applied changes, with newlines, tabs, and more respected.

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Paste code into Leo.
  2. Verify that newlines (or tabs/spaces) were preserved.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 4, 2024
@jonathansampson jonathansampson marked this pull request as ready for review October 4, 2024 21:42
Newline characters are being preserved, but not displayed. This change permits the newline characters to be impactful on the end-result, while still allowing natural wrapping of content. The change is applied exclusively to turn entries associated with user input.
@jonathansampson
Copy link
Contributor Author

Closing in favor of #25825

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/storybook-url Deploy storybook and provide a unique URL for each build feature/leo Leo-related issues and features release-notes/exclude UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AI Chat] Leo doesn't preserve newline characters
2 participants