Commits on Oct 7, 2024

1. [ubsan] Fix broken TestingPrefServiceSimple downcasts …

   The return type for this function has changed for a while now, so it
   appears we have been running over undefined behaviour all along.
   
   This change corrects the downcast to match the type returned by
   `GetPrefs()`, namely, `SearchEnginesTestEnvironment`, which in turn has
   ` sync_preferences::TestingPrefServiceSyncable` for its own
   `prefs_service()` method.
   
   Chromium changes:
   https://chromium.googlesource.com/chromium/src/+/2862d7f6b0842b53209c8038ec54eba132b55d8b
   https://chromium.googlesource.com/chromium/src/+/28881de3ad0bc41236fb00a794939ec7c0bff819
   
   commit 2862d7f6b0842b53209c8038ec54eba132b55d8b
   Author: Jack Yammine <[email protected]>
   Date:   Thu Jul 18 11:20:17 2024 +0000
   
       Remove deprecated TemplateURLService constructor used in tests
   
       This is part of a multi-CL change [2/4].
   
       We remove the TemplateURLService constructor that was only used for
       tests and update the tests accordingly.
   
       Bug: 40287734
   
   commit 28881de3ad0bc41236fb00a794939ec7c0bff819
   Author: Jack Yammine <[email protected]>
   Date:   Fri Jul 12 12:11:33 2024 +0000
   
       Correctly initialize TemplateURLService in tests
   
       We currently pass nullptr for PrefService and SearchEngineChoiceService
       in tests. This leads to having code paths in production that need
       to handle theses cases.
   
       This is part of a multi-CL change.
   
       Bug: 40287734

   

   cdesouza-chromium committed Oct 7, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d196071
   • Browse repository at this point

   Copy the full SHA

   d196071 View commit details

   Browse the repository at this point in the history