Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Move Activity to Portfolio View in Panel #25896

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

In preparation for the new Connection tab in the Wallet Panel, the Activity tab has now been moved into the Portfolio view under the Segmented Controller.

note:(This change is only in the Wallet Panel, the Desktop view does not change.)

Resolves brave/brave-browser#41498

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet Panel and navigate to the Portfolio screen
  2. You should now see Activity as an option in the Segmented Controller
  3. Click on Activity and make sure everything is working and displayed correctly.
  4. There should no longer be an Activity button in the main Wallet Panel navigation.
  5. Open the Wallet Desktop view, nothing should have changed.
Screen.Recording.mov

@Douglashdaniel Douglashdaniel self-assigned this Oct 8, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner October 8, 2024 22:54
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Oct 8, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit fefd08f into master Oct 9, 2024
18 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-move-activity-to-portfolio-view-in-panel branch October 9, 2024 14:35
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 9, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Activity Tab into Panel Portfolio View
3 participants