-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cr133] Remove all NOTREACHED_IN_MIGRATION
remaining
#26584
Open
cdesouza-chromium
wants to merge
1
commit into
master
Choose a base branch
from
remove-notreached-in-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-network-audit
Run network-audit
feature/web3/wallet
feature/web3/wallet/core
labels
Nov 15, 2024
tmancey
reviewed
Nov 15, 2024
tmancey
reviewed
Nov 15, 2024
tmancey
reviewed
Nov 15, 2024
chromium_src/third_party/blink/renderer/modules/plugins/dom_plugin_array.cc
Outdated
Show resolved
Hide resolved
tmancey
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++ (just a couple nits)
cdesouza-chromium
force-pushed
the
remove-notreached-in-migration
branch
from
November 15, 2024 15:35
8cec58c
to
971d6a8
Compare
yrliou
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallet++
`NOTREACHED_IN_MIGRATION` has now been deleted from chromium in M133. This was expected, and the existing occurrances have to be migrated to `NOTRECHEAD`. At this point, the only difference between `NOTREACHED`, and `NOTREACHED_IN_MIGRATION`, is that `NOTREACHED` is tagged as no return. Chromium change: https://chromium.googlesource.com/chromium/src/+/e238462dc67196d361ee0bbaf1954969619cab27 commit e238462dc67196d361ee0bbaf1954969619cab27 Author: Peter Boström <[email protected]> Date: Fri Nov 15 00:46:51 2024 +0000 Remove NOTREACHED_IN_MIGRATION() Bug: 40580068
cdesouza-chromium
force-pushed
the
remove-notreached-in-migration
branch
from
November 15, 2024 21:33
971d6a8
to
1956fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTREACHED_IN_MIGRATION
has now been deleted from chromium in M133. This was expected, and the existing occurrances have to be migrated toNOTRECHEAD
. At this point, the only difference betweenNOTREACHED
, andNOTREACHED_IN_MIGRATION
, is thatNOTREACHED
is tagged as no return.Chromium change:
https://chromium.googlesource.com/chromium/src/+/e238462dc67196d361ee0bbaf1954969619cab27
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: