Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cr133] Remove all NOTREACHED_IN_MIGRATION remaining #26584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Nov 15, 2024

NOTREACHED_IN_MIGRATION has now been deleted from chromium in M133. This was expected, and the existing occurrances have to be migrated to NOTRECHEAD. At this point, the only difference between NOTREACHED, and NOTREACHED_IN_MIGRATION, is that NOTREACHED is tagged as no return.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/e238462dc67196d361ee0bbaf1954969619cab27

commit e238462dc67196d361ee0bbaf1954969619cab27
Author: Peter Boström <[email protected]>
Date:   Fri Nov 15 00:46:51 2024 +0000

    Remove NOTREACHED_IN_MIGRATION()

    Bug: 40580068

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++ (just a couple nits)

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet++

`NOTREACHED_IN_MIGRATION` has now been deleted from chromium in M133.
This was expected, and the existing occurrances have to be migrated to
`NOTRECHEAD`. At this point, the only difference between `NOTREACHED`,
and `NOTREACHED_IN_MIGRATION`, is that `NOTREACHED` is tagged as no
return.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/e238462dc67196d361ee0bbaf1954969619cab27

commit e238462dc67196d361ee0bbaf1954969619cab27
Author: Peter Boström <[email protected]>
Date:   Fri Nov 15 00:46:51 2024 +0000

    Remove NOTREACHED_IN_MIGRATION()

    Bug: 40580068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants