Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Use proper components for ad-block (reflecting brave-core changes) #8100

Closed
cuba opened this issue Sep 20, 2023 · 1 comment · Fixed by #8321
Closed

Use proper components for ad-block (reflecting brave-core changes) #8100

cuba opened this issue Sep 20, 2023 · 1 comment · Fixed by #8321
Assignees
@cuba

Comments

@cuba
Copy link
Contributor

cuba commented Sep 20, 2023 •
edited
Loading

Description:

Adds changes related to brave-core updates here: brave/brave-browser#32799

Test strategy:

  1. Ensure settings prior to upgrade are remembered after the upgrade
  2. Test some general ad-blocking here
  3. Test cosmetic filtering here
  4. Test scriplets here
  5. Test some filter lists here (This test seems to broken)
  6. Test network blocking here (This test seems to be broken)
@cuba cuba self-assigned this Sep 20, 2023
cuba added a commit that referenced this issue Oct 12, 2023
@cuba
Fix #8100: Use proper ad-block components
bef88bd
cuba added a commit that referenced this issue Oct 17, 2023
@cuba
Fix #8100: Use proper ad-block components
cd57c3d
cuba added a commit that referenced this issue Oct 17, 2023
@cuba
Fix #8100: Use proper ad-block components
57f54e5
@cuba cuba mentioned this issue Oct 17, 2023
Merged
11 tasks
cuba added a commit that referenced this issue Oct 17, 2023
@cuba
Fix #8100: Use proper ad-block components
2e085bc
cuba added a commit that referenced this issue Oct 18, 2023
@cuba
Fix #8100: Use proper ad-block components
1743e9e
cuba added a commit that referenced this issue Oct 18, 2023
@cuba
Fix #8100: Use proper ad-block components
a1d6572
cuba added a commit that referenced this issue Oct 18, 2023
@cuba
Fix #8100: Use proper ad-block components
a45009c
cuba added a commit that referenced this issue Oct 20, 2023
@cuba
Fix #8100: Use proper ad-block components
f5f7c27
cuba added a commit that referenced this issue Oct 21, 2023
@cuba
Fix #8100: Use proper ad-block components (#8276)
28a5831
cuba added a commit that referenced this issue Oct 25, 2023
@cuba
Fix #8100: Use proper ad-block components
0aac110
@cuba cuba mentioned this issue Oct 25, 2023
Merged
11 tasks
StephenHeaps pushed a commit that referenced this issue Oct 25, 2023
@cuba @StephenHeaps
Fix #8100: Use proper ad-block components (#8276)
9f4ba02
iccub pushed a commit that referenced this issue Oct 25, 2023
@cuba
Uplift of #8100: Use proper ad-block components (uplift to 1.59.x) (#…
febca93 
…8312)

Fix #8100: Use proper ad-block components
cuba added a commit that referenced this issue Oct 26, 2023
@cuba
Fix #8100: Use proper ad-block components
4a3d899
@cuba cuba mentioned this issue Oct 26, 2023
Merged
11 tasks
iccub pushed a commit that referenced this issue Oct 26, 2023
@cuba
Uplift of #8100: Use proper ad-block components (uplift to 1.60.x) (#…
3676e8b 
…8321)

Fix #8100: Use proper ad-block components
@cuba
Copy link
Contributor Author

cuba commented Feb 13, 2024

This is already done. Not sure why its opened

@cuba cuba closed this as completed Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uplift of #8100: Use proper ad-block components (uplift to 1.60.x) brave/brave-ios
1 participant
@cuba