Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8100: Use proper ad-block components #8276

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Fix #8100: Use proper ad-block components #8276

merged 1 commit into from
Oct 21, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Oct 17, 2023 •
edited
Loading

Summary of Changes

This pull request fixes #8100

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

See issue for STR

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner October 17, 2023 20:17
@cuba cuba force-pushed the js/use-proper-adblock-components branch from 57f54e5 to 2e085bc Compare October 17, 2023 20:26
@cuba cuba force-pushed the js/use-proper-adblock-components branch from 2e085bc to 1743e9e Compare October 18, 2023 20:17
@cuba cuba force-pushed the js/use-proper-adblock-components branch from 1743e9e to a45009c Compare October 18, 2023 22:14
@kylehickinson kylehickinson added this to the 1.61 milestone Oct 20, 2023
@cuba cuba force-pushed the js/use-proper-adblock-components branch from a45009c to f5f7c27 Compare October 20, 2023 17:37
@cuba cuba merged commit 28a5831 into brave-core-1.61.x Oct 21, 2023
6 checks passed
@cuba cuba deleted the js/use-proper-adblock-components branch October 21, 2023 05:46
@cuba cuba mentioned this pull request Oct 25, 2023
Merged
11 tasks
StephenHeaps pushed a commit that referenced this pull request Oct 25, 2023
@cuba @StephenHeaps
Fix #8100: Use proper ad-block components (#8276)
9f4ba02
@cuba cuba mentioned this pull request Oct 26, 2023
Merged
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.61
Development

Successfully merging this pull request may close these issues.
3 participants
@cuba @iccub @kylehickinson