Calendar Setup and Permission Restructuring #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| async function toggleHostPerms( event ) { | ||
| const button = event.target.closest("button"); | ||
| const origin = button.dataset.origin.replace("*", ""); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[sveltegrep] button.dataset.origin.replace method will only replace the first occurrence when used with a string argument ("*"). If this method is used for escaping of dangerous data then there is a possibility for a bypass. Try to use sanitization library instead or use a Regex with a global flag.
Source: https://semgrep.dev/r/javascript.lang.security.audit.incomplete-sanitization.incomplete-sanitization
Cc @thypon @bcaller
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues. Primarily it introduces a new permission model which makes all permissions optional by default. This requires the user to explicitly opt-in to the Brave Talk for Calendars functionality on their preferred calendar(s). Secondly, to give the user the ability to identify which calendar(s) they use, this PR also introduces a new Calendar-Selection page.
The Calendar-Selection page is currently a work in progress. Here is it shown with Proton and Skiff enabled, but Google disabled:
Currently a single content script file is produced for all calendars, and injected into each calendar host when granted permission. The next step will be to generate a distinct content script for each host, and inject only the host-specific script when granted permission.