Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic wireframe for a new tab type #7290

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

zzhaobraze
Copy link
Collaborator

@zzhaobraze zzhaobraze commented May 1, 2024

Pull Request/Issue Resolution

Usage:

{% sdktabs %}
{% sdktab tab1 %}
Tab1 Content
{% endsdktab %}

{% sdktab Tab2 %}
Tab2 Content
{% endsdktab %}
{% endsdktabs %}

Example:

image

@cla-bot cla-bot bot added the cla-signed label May 1, 2024
@internetisaiah internetisaiah self-assigned this May 1, 2024
@josh-mccrowell-braze josh-mccrowell-braze added the status: do not merge Could mean research before "in progress" status, or do not merge yet. label May 21, 2024
@internetisaiah
Copy link
Contributor

internetisaiah commented Sep 13, 2024

Fixes needed:

  • The tab should still show even if there is only 1 {% sdktabs %} on the page. This is the default behavior on the existing {% tabs %} tag.
  • Fixed in commit 5e3a85e: The new SDK tab is reading both {% sdktabs %} and {% tabs %} as SDK tabs. Instead, regular tabs should be able to be fully nested inside SDK tabs. (See 1st image below for existing behavior).
  • When an SDK tab is selected, the TOC should only show the headings for the currently selected SDK tab. Currently all headings are shown regardless of the SDK tab selected.
  • When an SDK tab is selected, and there is a regular {% tabs %} tag in that section, the first tab should always be selected. Currently, if a new SDK tab is selected, all regular tabs in that section will be in an "unselected" state by default. (See 2nd image below).
  • Currently the page always defaults to the Swift tab, even if?sdktab=android is in the URL like http://127.0.0.1:5006/docs/developer_guide/sdk_integration/?sdktab=android

image
Screen Shot 2024-09-17 at 11 41 55 AM

cc @zzhaobraze

@zzhaobraze
Copy link
Collaborator Author

zzhaobraze commented Sep 16, 2024

@internetisaiah the added commit should fix these issue. If you update the branch and resolve the conflict, this should work now.

@internetisaiah
Copy link
Contributor

@zzhaobraze , thanks for the update! i already merged it into my other branch on friday and have been testing it out. works great!

@internetisaiah
Copy link
Contributor

@zzhaobraze , similar to {% tabs %} and {% subtabs %}, could we get an {% sdktabs %} and {% sdksubtabs %}?

As far as design goes, it can look and function exactly like a regular tab.

However in terms of nesting, it should go:

  • Highest level: {% sdktabs %}
  • Next level: {% sdksubtabs %}
  • Next level: {% tabs %}
  • Lowest level: {% subtabs %}

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 7:05pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed status: do not merge Could mean research before "in progress" status, or do not merge yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants