Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3735 Add IAM templates #8599

Merged
merged 11 commits into from
Dec 16, 2024
Merged

BD-3735 Add IAM templates #8599

merged 11 commits into from
Dec 16, 2024

Conversation

rachel-feinberg
Copy link
Contributor

@rachel-feinberg rachel-feinberg commented Dec 9, 2024

Why are you making this change? (required)

Adding new IAM drag-and-drop templates.

Related PRs, issues, or features (optional)

BD-3735

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great overall! I can tell you've really been mastering your diataxis skills--also great wording/phrasing as always 🫡 . i left some comments here and there.

note: some suggestions are only added to a single page in the PR but apply to multiple pages. it may help to do a command+F to make sure they are captured across all pages.


### Step 4: Style your message

You can customize the look and feel of your message using the drag-and-drop [in-app message components][3].
Customize the look and feel of your sign-up form using the drag-and-drop [in-app message components][3].

## Reporting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update these to maybe:

## Creating a report

or

## Analyzing the results

or something similar? i personally don't care too much on the language, but i think it would be good to make this action-based since its a "how-to" (based off of my understanding of the section's content).

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge whenever you're ready 👍🏽

@rachel-feinberg rachel-feinberg merged commit 3160003 into develop Dec 16, 2024
7 checks passed
@rachel-feinberg rachel-feinberg deleted the bd-3735 branch December 16, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants