-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BD-3735 Add IAM templates #8599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great overall! I can tell you've really been mastering your diataxis skills--also great wording/phrasing as always 🫡 . i left some comments here and there.
note: some suggestions are only added to a single page in the PR but apply to multiple pages. it may help to do a command+F to make sure they are captured across all pages.
|
||
### Step 4: Style your message | ||
|
||
You can customize the look and feel of your message using the drag-and-drop [in-app message components][3]. | ||
Customize the look and feel of your sign-up form using the drag-and-drop [in-app message components][3]. | ||
|
||
## Reporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we update these to maybe:
## Creating a report
or
## Analyzing the results
or something similar? i personally don't care too much on the language, but i think it would be good to make this action-based since its a "how-to" (based off of my understanding of the section's content).
...ssage_building_by_channel/in-app_messages/drag_and_drop/templates/email_confirmation_page.md
Show resolved
Hide resolved
.../message_building_by_channel/in-app_messages/drag_and_drop/templates/product_announcement.md
Outdated
Show resolved
Hide resolved
.../message_building_by_channel/in-app_messages/drag_and_drop/templates/product_announcement.md
Outdated
Show resolved
Hide resolved
..._guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/seasonal_promo.md
Outdated
Show resolved
Hide resolved
Co-authored-by: isaiah robinson <[email protected]>
...r_guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/email_capture.md
Outdated
Show resolved
Hide resolved
...ssage_building_by_channel/in-app_messages/drag_and_drop/templates/email_confirmation_page.md
Outdated
Show resolved
Hide resolved
..._guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/email_discount.md
Outdated
Show resolved
Hide resolved
...ser_guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/email_image.md
Outdated
Show resolved
Hide resolved
...ser_guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/email_offer.md
Outdated
Show resolved
Hide resolved
...user_guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/onboarding.md
Outdated
Show resolved
Hide resolved
.../message_building_by_channel/in-app_messages/drag_and_drop/templates/phone_number_capture.md
Outdated
Show resolved
Hide resolved
.../message_building_by_channel/in-app_messages/drag_and_drop/templates/product_announcement.md
Outdated
Show resolved
Hide resolved
..._guide/message_building_by_channel/in-app_messages/drag_and_drop/templates/seasonal_promo.md
Outdated
Show resolved
Hide resolved
…drag_and_drop/templates/seasonal_promo.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge whenever you're ready 👍🏽
Why are you making this change? (required)
Adding new IAM drag-and-drop templates.
Related PRs, issues, or features (optional)
BD-3735
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.