[website] Re-enable embeds (#4201)

Fixes #4176 Turns out the language pack was missing.
breadboard-ai · Jan 24, 2025 · 032cf64 · 032cf64
1 parent 9ba6ea3
commit 032cf64
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 8 deletions.
diff --git a/.changeset/clean-months-burn.md b/.changeset/clean-months-burn.md
@@ -0,0 +1,6 @@
+---
+"@breadboard-ai/shared-ui": patch
+"@google-labs/breadboard-website": patch
+---
+
+Re-enable embeds
diff --git a/packages/shared-ui/src/elements/editor/editor.ts b/packages/shared-ui/src/elements/editor/editor.ts
@@ -1532,7 +1532,7 @@ export class Editor extends LitElement implements DragConnectorReceiver {
     }
 
     const content = html`<div id="content">
-      ${this.graph
+      ${this.graph && !this.readOnly
         ? html`<div id="floating-buttons">
             <div id="start">
               <button

diff --git a/packages/shared-ui/src/strings/helper.ts b/packages/shared-ui/src/strings/helper.ts
@@ -9,7 +9,8 @@ import { LanguagePack, LanguagePackEntry } from "../types/types";
 class Strings<T extends LanguagePackEntry> {
   constructor(
     private name: string,
-    private values: T
+    private values: T,
+    private warnIfMissing = false
   ) {}
 
   from(key: string) {
@@ -21,9 +22,11 @@ class Strings<T extends LanguagePackEntry> {
       return this.values[key].str;
     }
 
-    console.warn(
-      `Missing language pack key "${key}" from section ${this.name}`
-    );
+    if (this.warnIfMissing) {
+      console.warn(
+        `Missing language pack key "${key}" from section ${this.name}`
+      );
+    }
     return key.toUpperCase();
   }
 }
@@ -34,12 +37,31 @@ export async function initFrom(language: LanguagePack) {
 }
 
 export function forSection<T extends keyof LanguagePack>(section: T) {
+  if (!currentLanguage) {
+    currentLanguage = {
+      ActivityLog: {},
+      AppPreview: {},
+      CommandPalette: {},
+      ComponentSelector: {},
+      Editor: {},
+      Global: {},
+      KitSelector: {},
+      ProjectListing: {},
+      UIController: {},
+      WorkspaceOutline: {},
+    };
+  }
   return new Strings(section, currentLanguage[section]);
 }
 
 export function from<T extends LanguagePack, Y extends keyof T>(
   lib: T,
-  name: Y
+  name: Y,
+  warnIfMissing = false
 ) {
-  return new Strings(name as string, lib[name] as LanguagePackEntry);
+  return new Strings(
+    name as string,
+    lib[name] as LanguagePackEntry,
+    warnIfMissing
+  );
 }
diff --git a/packages/website/src/js/board-embed.ts b/packages/website/src/js/board-embed.ts
@@ -3,6 +3,7 @@
  * Copyright 2024 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
+
 import { LitElement, html, css, TemplateResult, nothing } from "lit";
 import { customElement, property } from "lit/decorators.js";
 import { cache } from "lit/directives/cache.js";
@@ -13,7 +14,6 @@ import TemplateKit from "@google-labs/template-kit";
 import GeminiKit from "@google-labs/gemini-kit";
 import AgentKit from "@google-labs/agent-kit/agent.kit.json" assert { type: "json" };
 
-import "@breadboard-ai/shared-ui/editor";
 import "@breadboard-ai/shared-ui/editor";
 
 import {