Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local and head manifest schemas #2379

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add local and head manifest schemas #2379

wants to merge 11 commits into from

Conversation

Mearman
Copy link
Collaborator

@Mearman Mearman commented Jul 1, 2024

No description provided.

Mearman added 5 commits July 1, 2024 14:57
@Mearman
chore: Update schema package.json to include "./package.json" in the …
489418b 
…files section
@Mearman
refactor: Update generateSchemaId function to accept optional parameters
6c84a1e 
The generateSchemaId function in generate-schema-id.ts has been updated to accept an options object as a parameter, allowing for more flexibility in generating the schema ID. This change improves the maintainability and extensibility of the code.
@Mearman
chore: Add new schema files to package.json
0b79112
@Mearman
chore: Update manifest tests to use relative schema paths
4b5ee9c 
The manifest tests in index.test.ts have been updated to use relative schema paths instead of absolute paths. This change improves the portability and maintainability of the tests.
@Mearman
that one escaped
f630880
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 14da1e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Mearman Mearman self-assigned this Jul 1, 2024
@Mearman Mearman requested review from aomarks and paullewis and removed request for aomarks July 12, 2024 06:58
paullewis
paullewis requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@paullewis paullewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. I think it would be really helpful to boost the README, either in this PR or another, to briefly explain more of what this package does, and what the various local/head stuff means.

packages/manifest/src/tests/index.test.ts Outdated Show resolved Hide resolved
packages/manifest/src/tests/index.test.ts Outdated Show resolved Hide resolved
@Mearman Mearman requested a review from paullewis August 21, 2024 08:27
@TinaNikou
Copy link
Contributor

@paullewis Hello! I've removed the commented out code now 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullewis paullewis Awaiting requested review from paullewis

Requested changes must be addressed to merge this pull request.

Assignees

@Mearman Mearman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mearman @TinaNikou @paullewis