Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[board-server] simplify docker tags & enable multi platform builds for arm64/amd64 #2985

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[board-server] simplify docker tags & enable multi platform builds for arm64/amd64 #2985

wants to merge 16 commits into from

Conversation

wfaithfull
Copy link
Contributor

@wfaithfull wfaithfull commented Sep 2, 2024 •
edited
Loading

  • Enable linux/arm64, linux/amd64 and darwin/arm64 builds to cover more bases
  • Remove all tags other than latest and semver tags, as there seems to be something wrong with the sha tagged images.

Edit: can't do darwin/arm64 with the node base image

@wfaithfull
[pull] main from breadboard-ai:main (#159)
8ac4328 
See [Commits](//pull/159/commits) and
[Changes](//pull/159/files) for more details.

-----
Created by [<img src="https://prod.download/pull-18h-svg"
valign="bottom"/> **pull[bot]**](https://github.com/wei/pull)

_Can you help keep this open source service alive? **[💖 Please sponsor :
)](https://prod.download/pull-pr-sponsor)**_
@wfaithfull
feat: Enable multi-platform builds for board server
70c9a33
@wfaithfull
fix: remove sha256 tagging while we figure out what is wrong
6918f3f
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3eab1a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wfaithfull wfaithfull marked this pull request as draft September 2, 2024 18:35
@Mearman Mearman force-pushed the feat-multi-platform-docker-builds branch from 91ca032 to a40ce13 Compare September 16, 2024 14:33
@wfaithfull
Copy link
Contributor Author

@Mearman can we check in on where you got up to with this?

@Mearman
Copy link
Collaborator

Mearman commented Sep 18, 2024

@wfaithfull pipeline now actually tests the build.
you can see here where it was failing when trying to use darwin base image

@wfaithfull wfaithfull changed the title [board-server] multi platform docker builds [board-server] simplify docker tags & enable multi platform builds for arm64/amd64 Sep 18, 2024
@wfaithfull
Copy link
Contributor Author

Nature of this has somewhat changed from the original intent but @Mearman can you review & check if this all makes sense to you?

@wfaithfull wfaithfull marked this pull request as ready for review September 18, 2024 15:38
@wfaithfull wfaithfull requested a review from Mearman September 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mearman Mearman Awaiting requested review from Mearman

Assignees

@wfaithfull wfaithfull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfaithfull @Mearman