-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
954 write tests for cli OpenAPI import
#956
base: main
Are you sure you want to change the base?
954 write tests for cli OpenAPI import
#956
Conversation
|
a14b62e
to
fc03134
Compare
727a541
to
a6daab6
Compare
@wfaithfull is this complete? if not, shall I split of the async fixes into separate PR |
Let's just call this ready for now, I'd rather work smaller iterations on the code so any further stuff can go on top of this. @PaulKinlan do you want to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, but otherwise looks good.
thanks @Mearman for doing those suggestions for me. |
Anything we need to do here to get this unblocked? |
…port an openAPI spec, and fix a race condition bug arising from it.
07c8098
to
a26bbfd
Compare
Just had some conflicts to fix due to changes in import from main, hopefully this does the trick.. |
@PaulKinlan Heyo! I believe this PR is ready, so would you mind giving it a re-review please? 🫶 |
#954