Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

954 write tests for cli OpenAPI import #956

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Mearman
Copy link
Collaborator

@Mearman Mearman commented Mar 4, 2024

Copy link

changeset-bot bot commented Mar 4, 2024

⚠️ No Changeset found

Latest commit: 78e9cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Mearman Mearman closed this Mar 4, 2024
@Mearman Mearman force-pushed the 954-write-tests-for-cli-openapi-import- branch from a14b62e to fc03134 Compare March 4, 2024 15:21
@Mearman Mearman reopened this Mar 4, 2024
@wfaithfull wfaithfull force-pushed the 954-write-tests-for-cli-openapi-import- branch from 727a541 to a6daab6 Compare March 4, 2024 15:25
@Mearman
Copy link
Collaborator Author

Mearman commented Mar 5, 2024

@wfaithfull is this complete? if not, shall I split of the async fixes into separate PR

@wfaithfull
Copy link
Contributor

Let's just call this ready for now, I'd rather work smaller iterations on the code so any further stuff can go on top of this. @PaulKinlan do you want to take a look at this?

@Mearman Mearman marked this pull request as ready for review March 5, 2024 15:35
Copy link
Collaborator

@PaulKinlan PaulKinlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but otherwise looks good.

packages/breadboard-cli/src/commands/import.ts Outdated Show resolved Hide resolved
packages/breadboard-cli/src/commands/import.ts Outdated Show resolved Hide resolved
packages/breadboard-cli/src/commands/import.ts Outdated Show resolved Hide resolved
packages/breadboard-cli/src/commands/import.ts Outdated Show resolved Hide resolved
packages/breadboard-cli/src/commands/import.ts Outdated Show resolved Hide resolved
@wfaithfull
Copy link
Contributor

thanks @Mearman for doing those suggestions for me.

@PaulKinlan
Copy link
Collaborator

Anything we need to do here to get this unblocked?

@wfaithfull wfaithfull force-pushed the 954-write-tests-for-cli-openapi-import- branch from 07c8098 to a26bbfd Compare March 26, 2024 21:57
@wfaithfull
Copy link
Contributor

Just had some conflicts to fix due to changes in import from main, hopefully this does the trick..

@TinaNikou
Copy link
Contributor

@PaulKinlan Heyo! I believe this PR is ready, so would you mind giving it a re-review please? 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants