CORE-292: Define GEN interfaces; implement for XRP #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 19, 2019 16:10
# Conflicts: # crypto/BRCryptoWalletManager.c # crypto/BRCryptoWalletManager.h
Add gwmInstallFileService, gwmLoadTransfers, and gwmRecoverTransfer(). Define the Ripple file service types w/ handlers and implement *LoadTransfers. Implement the BRCryptoCWMClientGEN funcGetTransactions Swift callback. On cryptoWalletManagerCreate (for GEN): create GWM, create the primary wallet, restore the transactions and update the balance; signal the appropriate events along the way. To ripple/ add rippleTransactionSetCreate() to support restoring transactions.
# Conflicts: # Swift/BRCore.xcodeproj/project.pbxproj # Swift/BRCrypto/common/BRBlockChainDB.swift # crypto/BRCryptoAddress.c # crypto/BRCryptoPrivate.h # crypto/BRCryptoTransfer.c # crypto/BRCryptoWallet.c # crypto/BRCryptoWalletManager.c # crypto/BRCryptoWalletManagerClient.c # crypto/BRCryptoWalletManagerClient.h
# Conflicts: # Swift/BRCryptoDemo/CoreDemoAppDelegate.swift # crypto/BRCryptoHash.c # crypto/BRCryptoWallet.c
Unit tests broken... # Conflicts: # crypto/BRCryptoAccount.c
Implement for XRP.
michael-brd
reviewed
Jul 15, 2019
michael-brd
reviewed
Jul 15, 2019
michael-brd
reviewed
Jul 15, 2019
michael-brd
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends BRCrypto*.[ch] with implementations for BLOCK_CHAIN_TYPE_GEN. Defines generic/BRGeneric*.[ch] and implements those interfaces using the XRP interfaces.
Changes are of five types:
The bulk of the change is in #1 above.
This is a 'preemptive merge'; although the unit tests pass (now that they are fixed), the XRP changes have not be tested with the BlockchainDB and there are an unknown or two on XRP account serialization (CORE-414)