Merge pull request #137 from breakroom/finch-pool-metrics

Enable Finch pool metrics
breakroom · Jan 13, 2025 · 459e33b · 459e33b
2 parents f96f8be + 275a4f9
commit 459e33b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/snap/http_client/adapters/finch.ex b/lib/snap/http_client/adapters/finch.ex
@@ -66,7 +66,7 @@ defmodule Snap.HTTPClient.Adapters.Finch do
     finch_config = [
       name: connection_pool_name(cluster),
       pools: %{
-        url => [size: size, count: 1, conn_opts: conn_opts]
+        url => [size: size, count: 1, conn_opts: conn_opts, start_pool_metrics?: true]
       }
     ]
 

diff --git a/test/http_client/adapters/finch_test.exs b/test/http_client/adapters/finch_test.exs
@@ -13,7 +13,14 @@ defmodule Snap.HTTPClient.Adapters.FinchTest do
       assert {Finch,
               [
                 name: Snap.Test.Cluster.Pool,
-                pools: %{"http://localhost:9200" => [size: 5, count: 1, conn_opts: []]}
+                pools: %{
+                  "http://localhost:9200" => [
+                    size: 5,
+                    count: 1,
+                    conn_opts: [],
+                    start_pool_metrics?: true
+                  ]
+                }
               ]} == FinchAdapter.child_spec(config)
     end
 
@@ -98,6 +105,11 @@ defmodule Snap.HTTPClient.Adapters.FinchTest do
     end
   end
 
+  test "should be able to retreive Finch pool metrics" do
+    assert {:ok, [%Finch.HTTP1.PoolMetrics{}]} =
+             Finch.get_pool_status(Snap.Test.Cluster.Pool, {:http, "localhost", 9200})
+  end
+
   defp build_config(extra_config \\ []) do
     default_config = [
       cluster: Snap.Test.Cluster,