Improve error reporting for help topic callbacks

breezy-team · Sep 29, 2023 · f0d4458 · f0d4458
1 parent 1166301
commit f0d4458
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/crates/cmd-py/src/help.rs b/crates/cmd-py/src/help.rs
@@ -73,10 +73,14 @@ impl HelpTopicRegistry {
             breezy::help::HelpContents::Closure(Box::new(move |_| contents.clone()))
         } else {
             let f = contents.extract::<PyObject>(py)?;
+            let name = name.to_string();
             breezy::help::HelpContents::Closure(Box::new(move |h| {
-                Python::with_gil(|py| {
-                    let s = f.call1(py, (h,)).unwrap();
-                    s.extract::<String>(py).unwrap()
+                Python::with_gil(|py| match f.call1(py, (h,)) {
+                    Ok(s) => s.extract::<String>(py).unwrap(),
+                    Err(e) => {
+                        e.print(py);
+                        panic!("error while generating help text for {}", name);
+                    }
                 })
             }))
         };