feat(BREV-2068,BREV-2069,BREV-2070,BREV-2071): Managed k8s, VPC support for AWS, Nebius #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmalin
changed the title
|
Will set up test keys to enable e2e validation shortly. |
patelspratik
reviewed
Nov 4, 2025
| case *rsa.PrivateKey, *ed25519.PrivateKey: | ||
| return k, nil | ||
| default: | ||
| return nil, fmt.Errorf("key is not an RSA private key") |
There was a problem hiding this comment.
should we not waterfall on error all the way through, or if the parse succeeds, then that means we are in that key format?
patelspratik
reviewed
Nov 4, 2025
| t.Fatalf("failed to get VPC: %v", err) | ||
| } | ||
|
|
||
| // err = awsClient.DeleteVPC(context.Background(), v1.DeleteVPCArgs{ |
patelspratik
reviewed
Nov 4, 2025
| } | ||
| } | ||
| return false | ||
| return slices.Contains(c, cc) |
patelspratik
reviewed
Nov 4, 2025
| CapabilityCreateInstance Capability = "create-instance" | ||
| CapabilityCreateIdempotentInstance Capability = "create-instance-idempotent" | ||
| CapabilityTerminateInstance Capability = "terminate-instance" | ||
| CapabilityCreateTerminateInstance Capability = "create-terminate-instance" |
There was a problem hiding this comment.
this verbage is a bit weird, might be worth a comment to explain what this means
patelspratik
reviewed
Nov 4, 2025
| name string | ||
|
|
||
| // The unique ID used to associate with this cluster. | ||
| refID string |
There was a problem hiding this comment.
is the implication that this is a Brev ID? or said another way, what is the difference between id and refId?
patelspratik
reviewed
Nov 4, 2025
| errs = append(errs, fmt.Errorf("clusterServerURL is required")) | ||
| } | ||
| if s.Username == "" { | ||
| errs = append(errs, fmt.Errorf("username is required")) |
There was a problem hiding this comment.
does this have to be unique per cluster?
patelspratik
reviewed
Nov 4, 2025
| cloud string | ||
|
|
||
| // The ID assigned by the cloud provider to the VPC. | ||
| id CloudProviderResourceID |
There was a problem hiding this comment.
quibble: maintain ordering in our interfaces, kubernetes had this field first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.