Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: add rule: no-unreachable #3263

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

eslint: add rule: no-unreachable #3263

wants to merge 5 commits into from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Jun 19, 2024 •
edited
Loading

No description provided.

alxndrsn added 2 commits June 19, 2024 15:11
eslint: add rule: no-unreachable
6b088df 
Also delete tests which have not been enabled since 2017.
Merge branch 'master' into eslint-no-unreachable
b3e4e16
@alxndrsn
Copy link
Contributor Author

@brianc is there anything I can do to help get this PR considered for review?

charmander
charmander requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@charmander charmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d merge this if it were just the ESLint rule. Don’t want to combine two unrelated changes.

@alxndrsn
Copy link
Contributor Author

I’d merge this if it were just the ESLint rule. Don’t want to combine two unrelated changes.

Thanks for the feedback. I've reverted the unrelated changes.

@charmander
Copy link
Collaborator

Oh, I see there are no code changes associated with this. How about applying the entire ESLint recommended configuration, then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxndrsn @charmander