bundle/cors: introduction #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll surely want to reconfigure whether we accept cross-origin cookies at some point, but let's just try this for now.
flask-cors supports app-level config already: https://github.com/corydolphin/flask-cors/blob/9f56fd79b081c19876ccdabdf217e9f36260c4a4/flask_cors/core.py#L298 So, all we do here is expose the same config vars in our bundle, where the default values can be overridden, and then picked up automatically by flask-cors.
| class Config(BundleConfig): | ||
| # Default values; override as necessary | ||
| CORS_ORIGINS = '*' | ||
| CORS_METHODS = ALL_METHODS |
There was a problem hiding this comment.
Upstream's default is already all methods so I think we can leave this out (the ALL_METHODS constant from flask_unchained is perhaps confusingly named, it doesn't include HEAD)
| from flask_cors import CORS as BaseCORS | ||
|
|
||
|
|
||
| class CORS(object): |
There was a problem hiding this comment.
I don't think this class is necessay - upstream's extension code seems to work as-is.
| @@ -9,6 +9,7 @@ dill==0.2.8.2 | |||
| flask==1.0.2 | |||
| flask-admin==1.5.1 | |||
| flask_babelex==0.9.3 | |||
| flask-cors==3.0.7 | |||
There was a problem hiding this comment.
We also want to add this to setup.py's extra_requires
| @@ -0,0 +1,15 @@ | |||
| from .cors import CORS | |||
There was a problem hiding this comment.
from flask_cors import CORS
should be enough :)
briancappello
force-pushed
the
master
branch
23 times, most recently
from
69507ab to
5a6f14a
Compare
briancappello
force-pushed
the
master
branch
2 times, most recently
from
ef3c90a to
c1823ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new bundle to provide CORS support.
Note: let me know what else you'd like to see before accepting this PR for merge, such as tests (or other).
Also: regarding this bundle's config, I haven't actually tested that overriding the settings will propagate all the way into
flask-cors; it's just based on my reading of theflask-corscode, and my sorta vague understanding of bundle initialization. I linked to the code inflask-corsin my commit log that makes me think it will Just Work.