Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV(1.64): Use core::ffi::{c_char, c_int, c_uint, CStr} & simplify CI. #1829

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briansmith
Copy link
Owner

We can use these after the recent MSRV bump.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.71%. Comparing base (6f9a387) to head (d9a6dc3).

Files Patch % Lines
src/polyfill/cstr.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
+ Coverage   96.70%   96.71%   +0.01%     
==========================================
  Files         145      144       -1     
  Lines       20763    20731      -32     
  Branches      244      244              
==========================================
- Hits        20079    20051      -28     
+ Misses        650      646       -4     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith changed the title NFC: Use core::ffi::{c_int,c_uint}. MSRV(1.64): Use core::ffi::{c_int,c_uint}. Nov 27, 2023
@briansmith briansmith force-pushed the b/safer-int branch 9 times, most recently from e249bfd to aaa9ff9 Compare May 19, 2024 01:41
@briansmith briansmith changed the title MSRV(1.64): Use core::ffi::{c_int,c_uint}. MSRV(1.64): Use core::ffi::{c_char, c_int, c_uint, CStr} & simplify CI. May 19, 2024
@briansmith briansmith force-pushed the b/safer-int branch 2 times, most recently from ed90306 to f1455ee Compare May 19, 2024 03:07
* Use core::ffi::{c_int, c_uint} and remove our polyfills,
  eliminating libc as a dev-dependency.
* Somplify CI configuration for symbol prefixing since 1.64.0 has
  llvm-tools-preview.
* Use `core::ffi::CStr` in aarch64-apple-* feature detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant