Skip to content

Commit

Permalink
Move download_from_gcs to cobalt/tools
Browse files Browse the repository at this point in the history
This belongs to Cobalt; tools belongs to Chromium.

Issue: 169056570
Reviewed-on: youtube#3114
  • Loading branch information
dahlstrom-g committed Apr 30, 2024
1 parent 86ca328 commit c21f78e
Show file tree
Hide file tree
Showing 11 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ files: |
starboard|
tools/metrics/actions/cobalt|
tools/metrics/histograms/metadata/cobalt|
tools/testing|
)/
| ^[^/]+$ # files in the root
)
Expand Down Expand Up @@ -176,7 +175,7 @@ repos:
pass_filenames: false
always_run: true
stages: [push]
args: [-m, unittest, tools/download_from_gcs_test.py]
args: [-m, unittest, cobalt/tools/download_from_gcs_test.py]
- id: test-python3-compatibility
name: Test Python 3 Compatibility
description: Checks that scripts can be run in Python 3
Expand Down
2 changes: 1 addition & 1 deletion cobalt/media/testing/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import("//cobalt/media/testing/data/sha1_files.gni")
action("cobalt_media_download_test_data") {
install_content = true

script = "//tools/download_from_gcs.py"
script = "//cobalt/tools/download_from_gcs.py"

sha_sources = []
foreach(sha1_file, sha1_files) {
Expand Down
2 changes: 1 addition & 1 deletion cobalt/renderer/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ copy("renderer_copy_lottie_test_data") {
action("renderer_download_lottie_test_data") {
install_content = true

script = "//tools/download_from_gcs.py"
script = "//cobalt/tools/download_from_gcs.py"

inputs = [
"$_lottie_resource_path/finger_print-expected.png.sha1",
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import tempfile
import unittest

from tools import download_from_gcs
from cobalt.tools import download_from_gcs

_BUCKET = 'chromium-clang-format'
_HASH_FILE_EXT = '.sha1'
Expand Down
2 changes: 1 addition & 1 deletion components/crx_file/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if (is_starboard) {
action("crx_file_download_test_data") {
install_content = true

script = "//tools/download_from_gcs.py"
script = "//cobalt/tools/download_from_gcs.py"

sha_sources = []
foreach(sha1_file, sha1_files) {
Expand Down
2 changes: 1 addition & 1 deletion download_resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
except ImportError:
import urllib2 as urllib

from tools import download_from_gcs
from cobalt.tools import download_from_gcs


def DownloadGerritCommitMsgHook(force=False):
Expand Down
2 changes: 1 addition & 1 deletion starboard/shared/starboard/player/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static_library("video_dmp") {
action("player_download_test_data") {
install_content = true

script = "//tools/download_from_gcs.py"
script = "//cobalt/tools/download_from_gcs.py"

sha_sources = []
foreach(sha1_file, sha1_files) {
Expand Down

0 comments on commit c21f78e

Please sign in to comment.