Fix not returning WindowId when valid.

b/342003753
briantting · May 29, 2024 · e786301 · e786301
1 parent 05cfe09
commit e786301
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cobalt/webdriver/protocol/window_id.cc b/cobalt/webdriver/protocol/window_id.cc
@@ -23,8 +23,11 @@ const char kWindowNameKey[] = "name";
 
 base::Optional<WindowId> WindowId::FromValue(const base::Value* value) {
   const base::Value::Dict* dictionary_value = value->GetIfDict();
-  if (!dictionary_value) {
-    return absl::nullopt;
+  if (dictionary_value) {
+    const std::string* window_id = dictionary_value->FindString(kWindowNameKey);
+    if (window_id) {
+      return WindowId(*window_id);
+    }
   }
   return base::nullopt;
 }