WIP: add fullname if note is added or updated on a board after adding…

… or updating in an other browser by an other user

amd/src/board.js

@@ -1171,12 +1171,14 @@ export default function(settings) {
 
                 var data = JSON.parse(item.content);
                 if (item.action == 'add_note') {
+                    // This is called on a board if someone else has added a note in a different browser.
                     let sortorder = sortby == 3 ? data.sortorder : data.timecreated;
                     addNote(data.columnid, data.id, data.heading, data.content, data.attachment,
-                        {id: item.userid}, sortorder, data.rating);
+                        {id: item.userid , fullname: item.userid + " " + item.fullname}, sortorder, data.rating);
                     updateNoteAria(data.id);
                     sortNotes($('.board_column[data-ident=' + data.columnid + '] .board_column_content'));
                 } else if (item.action == 'update_note') {
+                    // This is called on a board if someone else has updated a note in a different browser.
                     let note = getNote(data.id),
                         formModal = editModal,
                         historyData = data;

classes/board.php

@@ -77,7 +77,7 @@ class board {
     /** @var int Value for the singleusermode setting in public mode*/
     const SINGLEUSER_PUBLIC = 2;
 
-     static $alluserids = [];
+    static $alluserids = [];
 
     /**
      * Retrieves the course module for the board
@@ -440,8 +440,20 @@ public static function board_history(int $boardid, int $ownerid, int $since): ar
                 $params['ownerid'] = $ownerid;
             }
         }
-
-        return $DB->get_records_select('board_history', $condition, $params);
+        $history_items = $DB->get_records_select('board_history', $condition, $params);
+        // Add fullname to each item in history if author should be displayed.
+        $config = get_config('mod_board');
+        $allowshowauthorofnoteonboard = isset($config->allowshowauthorofnoteonboard) ? $config->allowshowauthorofnoteonboard : false;
+        if ($allowshowauthorofnoteonboard && self::board_show_authorofnote($board->id)) {
+            foreach ($history_items as $history_item) {
+                if (!self::$alluserids[$history_item->userid]) {
+                    $user = core_user::get_user($history_item->userid);
+                    self::$alluserids[$history_item->userid] = fullname($user);
+                }
+                $history_item->fullname =self::$alluserids[$history_item->userid];
+            }
+        }
+        return $history_items;
     }
 
     /**

external.php

@@ -75,6 +75,7 @@ public static function board_history_returns(): external_multiple_structure {
                     'boardid' => new external_value(PARAM_INT, 'boardid'),
                     'action' => new external_value(PARAM_TEXT, 'action'),
                     'userid' => new external_value(PARAM_INT, 'userid'),
+                    'fullname' => new external_value(PARAM_TEXT, 'user fullname', VALUE_DEFAULT, ''),
                     'content' => new external_value(PARAM_RAW, 'content')
                 )
             )