WIP: feature #100 - Show author of comment #108
+133
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schulportalhessen
force-pushed
the
showownerofcomments-new-MOODLE_401_STABLE
branch
from
0aa4ee1
to
d40b3e0
Compare
schulportalhessen
changed the title
…activated fix: deactivating showcommentusername does is not stored in db, only activating is possible changes during code review remove empty rows use smaler versionnumber
…t showauthorofcomment
schulportalhessen
force-pushed
the
showownerofcomments-new-MOODLE_401_STABLE
branch
from
d40b3e0
to
3bdb0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #100
This pull request adds the feature that a siteadmin can activate the feature to show the author of a comment.
The teacher in a course can configure to hide (default) or show the autor.
Above the board the users can see an information if or if not the author will be displayed depending on the configuration of the board.
In line 707 or 720
foreach ($notes as $note)does not loop the notes but it loops the comments.
So we we changed the loop to
foreach ($notecomments as $notecomment)This does not not fix #25 if post does not mean comment on notes.
To show author of notes added to the board a similar implementation will be added different be a pull request.