Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Add new checks to match run checks #6868

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Nov 22, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Add CKV2_AZURE_55 to match 424a5e77-8997-47d9-b0e0-daaca8b81b01 Azure Spring Cloud app end-to-end TLS is disabled
  • Add CKV_AZURE_245 to match d480c1d2-06b3-4e53-81c9-a21ed83cb5fc Azure Container Instance is not configured with virtual network
  • Add CKV_AZURE_246 to match 0429670c-5d2d-4d0f-ab33-59eb5e000305 Azure AKS cluster HTTP application routing enabled

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes




Generated description

Below is a concise technical summary of the changes proposed in this PR:

This pull request introduces new test files for the Terraform runner, specifically focusing on plan execution and general runner functionality. The changes aim to enhance the test coverage and ensure the robustness of the Terraform runner.

TopicDetails
Terraform Runner Tests Test the functionality of the Terraform runner.
Modified files (2)
  • tests/terraform/runner/test_plan_runner.py
  • tests/terraform/runner/test_runner.py
Latest Contributors(2)
UserCommitDate
rotemavnifix-terraform-Set-time...October 13, 2024
tsmithv11feat-terraform-New-che...September 19, 2024
AWS Security Checks Implement AWS security group checks to prevent unrestricted egress.
Modified files (4)
  • tests/terraform/checks/resource/aws/test_SecurityGroupUnrestrictedEgressAny.py
  • checkov/terraform/checks/resource/aws/SecurityGroupUnrestrictedEgressAny.py
  • checkov/terraform/checks/resource/aws/AbsSecurityGroupUnrestrictedEgress.py
  • tests/terraform/checks/resource/aws/example_SecurityGroupUnrestrictedEgressAny/main.tf
Latest Contributors(0)
UserCommitDate
Azure Security Checks Add checks for Azure resources to ensure secure configurations.
Modified files (11)
  • tests/terraform/checks/resource/azure/test_AzureContainerInstancePublicIPAddressType.py
  • checkov/terraform/checks/resource/azure/AzureContainerInstancePublicIPAddressType.py
  • tests/terraform/image_referencer/test_runner_azure_resources.py
  • tests/terraform/checks/resource/azure/test_KubernetesClusterHTTPApplicationRouting.py
  • checkov/terraform/checks/resource/azure/KubernetesClusterHTTPApplicationRouting.py
  • tests/terraform/graph/checks/test_yaml_policies.py
  • tests/terraform/graph/checks/resources/AzureSpringCloudTLSDisabled/expected.yaml
  • tests/terraform/checks/resource/azure/example_AzureContainerInstancePublicIPAddressType/main.tf
  • tests/terraform/graph/checks/resources/AzureSpringCloudTLSDisabled/main.tf
  • tests/terraform/checks/resource/azure/example_KubernetesClusterHTTPApplicationRouting/main.tf
  • checkov/terraform/checks/graph_checks/azure/AzureSpringCloudTLSDisabled.yaml
Latest Contributors(2)
UserCommitDate
tdefisefix-terraform-Added-ap...October 16, 2024
tsmithv11feat-terraform-2-new-c...October 14, 2024
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 changed the title feat(terrraform): Add new checks to match run checks feat(terraform): Add new checks to match run checks Nov 22, 2024
@tsmithv11 tsmithv11 marked this pull request as ready for review November 22, 2024 21:58
This reverts commit 1be3da1.
@tsmithv11 tsmithv11 merged commit a3c3a28 into main Nov 27, 2024
38 of 39 checks passed
@tsmithv11 tsmithv11 deleted the mikhail-checks-nov24 branch November 27, 2024 13:52
Saarett pushed a commit that referenced this pull request Nov 27, 2024
* Add check for 424a5e77-8997-47d9-b0e0-daaca8b81b01

* Add check for d480c1d2-06b3-4e53-81c9-a21ed83cb5fc

* Add egress check

* Fix test

* Adjust tests

* Add new NSG check

* Revert "Add new NSG check"

This reverts commit 1be3da1.

* New check

* Fix ID
Saarett pushed a commit that referenced this pull request Nov 27, 2024
* Add check for 424a5e77-8997-47d9-b0e0-daaca8b81b01

* Add check for d480c1d2-06b3-4e53-81c9-a21ed83cb5fc

* Add egress check

* Fix test

* Adjust tests

* Add new NSG check

* Revert "Add new NSG check"

This reverts commit 1be3da1.

* New check

* Fix ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants