-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Add new checks to match run checks #6868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmithv11
requested a deployment
to
scan-security
November 22, 2024 20:48
— with
GitHub Actions
Waiting
tsmithv11
changed the title
feat(terrraform): Add new checks to match run checks
feat(terraform): Add new checks to match run checks
Nov 22, 2024
tsmithv11
requested a deployment
to
scan-security
November 22, 2024 21:10
— with
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
November 22, 2024 21:30
— with
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
November 22, 2024 21:57
— with
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
November 22, 2024 22:19
— with
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
November 23, 2024 05:56
— with
GitHub Actions
Waiting
This reverts commit 1be3da1.
tsmithv11
requested a deployment
to
scan-security
November 23, 2024 06:03
— with
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
November 24, 2024 01:21
— with
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
November 24, 2024 01:22
— with
GitHub Actions
Waiting
bo156
approved these changes
Nov 27, 2024
ChanochShayner
approved these changes
Nov 27, 2024
tsmithv11
requested a deployment
to
scan-security
November 27, 2024 13:37
— with
GitHub Actions
Waiting
Saarett
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Add check for 424a5e77-8997-47d9-b0e0-daaca8b81b01 * Add check for d480c1d2-06b3-4e53-81c9-a21ed83cb5fc * Add egress check * Fix test * Adjust tests * Add new NSG check * Revert "Add new NSG check" This reverts commit 1be3da1. * New check * Fix ID
Saarett
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Add check for 424a5e77-8997-47d9-b0e0-daaca8b81b01 * Add check for d480c1d2-06b3-4e53-81c9-a21ed83cb5fc * Add egress check * Fix test * Adjust tests * Add new NSG check * Revert "Add new NSG check" This reverts commit 1be3da1. * New check * Fix ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
424a5e77-8997-47d9-b0e0-daaca8b81b01
Azure Spring Cloud app end-to-end TLS is disabledd480c1d2-06b3-4e53-81c9-a21ed83cb5fc
Azure Container Instance is not configured with virtual network0429670c-5d2d-4d0f-ab33-59eb5e000305
Azure AKS cluster HTTP application routing enabledChecklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
This pull request introduces new test files for the Terraform runner, specifically focusing on plan execution and general runner functionality. The changes aim to enhance the test coverage and ensure the robustness of the Terraform runner.
Modified files (2)
Latest Contributors(2)
Modified files (4)
Latest Contributors(0)
Modified files (11)
Latest Contributors(2)