Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Fix two checks and logs #6874

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix(terraform): Fix two checks and logs #6874

merged 2 commits into from
Nov 26, 2024

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Nov 26, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes #6841

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Improve logging and fix checks in Block, S3GlobalViewACL, and S3SecureDataTransport classes. Update logging level from warning to debug in Block class to reduce log noise. Enhance S3GlobalViewACL and S3SecureDataTransport checks by adding type checks to prevent errors when processing grants.

TopicDetails
Logging Enhancement Improve logging in Block class to reduce log noise.
Modified files (1)
  • checkov/common/graph/graph_builder/graph_components/blocks.py
Latest Contributors(2)
UserCommitDate
bo156fix-general-Used-jsonp...November 19, 2024
taviassaffeat-azure-add-new-pol...November 17, 2024
S3 Checks Fix Fix type checks in S3 checks to prevent errors.
Modified files (2)
  • checkov/terraform/checks/resource/aws/S3GlobalViewACL.py
  • checkov/terraform/checks/resource/aws/S3SecureDataTransport.py
Latest Contributors(1)
UserCommitDate
tsmithv11feat-terraform-Add-s3-...October 14, 2024
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

Copy link
Contributor

@Saarett Saarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsmithv11 Looks good! Any test cases to support those changes?

@tsmithv11
Copy link
Collaborator Author

@tsmithv11 Looks good! Any test cases to support those changes?

I couldn't replicate it without a heavy unit test. WDYT?

@tsmithv11 tsmithv11 merged commit 4db0683 into main Nov 26, 2024
42 checks passed
@tsmithv11 tsmithv11 deleted the fix-checks-nov24 branch November 26, 2024 13:17
Saarett pushed a commit that referenced this pull request Nov 26, 2024
* Fix checks and logs

* Fix flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 3.2.256 introduces some errors while scanning Terraform s3 module
4 participants