Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arm): Fix arm report resource naming #6876

Merged
merged 16 commits into from
Nov 26, 2024
Merged

Conversation

omriyoffe-panw
Copy link
Contributor

@omriyoffe-panw omriyoffe-panw commented Nov 26, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Refactor the Runner class in checkov/arm/runner.py to improve resource path handling by introducing a clean_file_path function. This change ensures that resource paths are consistently formatted, enhancing the accuracy of resource reporting. Additionally, update the test cases in tests/arm/runner/test_runner.py to align with the new path handling logic, ensuring that the relative paths are correctly validated against the expected format.

TopicDetails
Test Case Updates Update test cases to align with the new path handling logic, ensuring correct validation of relative paths.
Modified files (1)
  • tests/arm/runner/test_runner.py
Latest Contributors(2)
UserCommitDate
omriyoffe-panwfix-arm-Fix-arm-resour...November 25, 2024
gruebelbreak-general-remove-m...October 24, 2023
Resource Path Handling Refactor the Runner class to improve resource path handling by introducing a clean_file_path function.
Modified files (1)
  • checkov/arm/runner.py
Latest Contributors(2)
UserCommitDate
omriyoffe-panwfix-arm-Fix-arm-resour...November 25, 2024
lirshindalmanfeat-arm-Add-arm-defin...October 30, 2024
This pull request is reviewed by Baz. Join @omriyoffe-panw and the rest of your team on (Baz).

@omriyoffe-panw omriyoffe-panw merged commit 8b17e65 into main Nov 26, 2024
42 checks passed
@omriyoffe-panw omriyoffe-panw deleted the fix-arm-breadcrumbs branch November 26, 2024 12:50
Saarett pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants