Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arm): Fix arm root folder #6880

Merged
merged 18 commits into from
Nov 27, 2024
Merged

fix(arm): Fix arm root folder #6880

merged 18 commits into from
Nov 27, 2024

Conversation

omriyoffe-panw
Copy link
Contributor

@omriyoffe-panw omriyoffe-panw commented Nov 27, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Refactor the Runner class in checkov/arm/runner.py to improve the handling of the root_folder attribute and enhance file path management. The changes ensure that the root_folder is set correctly and utilize Path for absolute file paths, replacing os.path.abspath. This update aims to fix issues related to ARM root folder processing and improve code readability and maintainability.

TopicDetails
Runner Refactor Refactor the Runner class to improve root folder handling and file path management.
Modified files (1)
  • checkov/arm/runner.py
Latest Contributors(2)
UserCommitDate
omriyoffe-panwfix-arm-Fix-arm-report...November 26, 2024
lirshindalmanfeat-arm-Add-arm-defin...October 30, 2024
This pull request is reviewed by Baz. Join @omriyoffe-panw and the rest of your team on (Baz).

@omriyoffe-panw omriyoffe-panw merged commit 7d3b8fc into main Nov 27, 2024
42 checks passed
@omriyoffe-panw omriyoffe-panw deleted the fix-arm-breadcrumbs branch November 27, 2024 13:24
Saarett pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants