Ability to add remote poster and thumbnails to a video #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I functionality e.g. for schedule start_date and end_date
tamasd
suggested changes
Jul 5, 2018
| $this->fieldChanged('remote_url'); | ||
| return $this; | ||
| } | ||
| } |
| $this->fieldChanged('remote_url'); | ||
| return $this; | ||
| } | ||
| } |
| @@ -56,7 +56,7 @@ protected function canonicalFieldName($name) { | |||
| public function postJSON() { | |||
| $data = []; | |||
| foreach ($this as $field => $val) { | |||
| if ($field === 'changedFields' || $field === 'fieldAliases' || $val === NULL) { | |||
| @@ -84,9 +84,6 @@ public function patchJSON() { | |||
| $data = []; | |||
| foreach ($this->changedFields as $field) { | |||
| $val = $this->{$field}; | |||
| if ($val === NULL) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some work where I need to change the images on a video to remote images uploaded in our own CMS.
There might be a few more endpoints I add in later, but for now here's the work I've done for adding remote images.