Fix upload not working when the agent cannot be deployed #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the agent cannot be deployed the `upload` command fails as `remote_block_size` is not set. This commit sets `remote_block_size` to 1 by default.
The current upload function calculates the available space in the remote system using `df` and by specifying the block size using the `--block-size` flag. That flag exists only in GNU version of `df` but it fails with BusyBox or Toybox version of `df`. The `-k` flag, which sets the block size to 1024 bytes, is preferred as common among different implementations of `df`.
|
Updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the agent cannot be deployed the
uploadcommand fails asremote_block_sizeis not set. This commit setsremote_block_sizeto 1 by default.