Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Hide sidetool unfocused #167

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

flurryrush
Copy link
Contributor

I'm really sorry, I didn't properly test the previous implementation after using the hasFocus boolean directly. Turns out this prevents the toolbar from opening at all.

I've reverted the commits and implemented a css-based solution. This will not work in all browsers though.

Sorry for the trouble!

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files          15       15           
  Lines         349      349           
  Branches       50       50           
=======================================
  Hits          285      285           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a231e...62c4c09. Read the comment docs.

@brijeshb42
Copy link
Owner

brijeshb42 commented Jun 5, 2019

I think you should update the PR to revert the previous one without this css change. Since updating css solves your problem, you can apply this directly in your project stylesheet and do nothing in medium-draft itself as no one else has raised this particular issue.

@flurryrush flurryrush force-pushed the hide-sidetool-unfocused branch from 75ff4d3 to 62c4c09 Compare June 12, 2019 07:19
@flurryrush
Copy link
Contributor Author

Alright, done. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants