Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planck PR4: Lollipop and Hillipop #356

Open
wants to merge 29 commits into
base: 3.6
Choose a base branch
from
Open

Conversation

mtristram
Copy link

Here are likelihoods for MontePython based on the PR4:

  • Hillipop: Planck20_Hillipop_TT, Planck20_Hillipop_TTTEEE, Planck20_Hillipop_TT_lite, Planck20_Hillipop_TTTEEE_lite
  • Lollipop: Planck20_Lollipop_EE, Planck20_Lollipop_BB, Planck20_Lollipop_EB

@brinckmann brinckmann mentioned this pull request Feb 21, 2024
@schoeneberg
Copy link

Hey both,

I just wanted to let you know that I also created a version of the likelihoods that

  • Doesn't require any pip install
  • Works natively in montepython without requiring cobaya
  • Has the option not to require nonlinear=halofit
  • Has the option to set the peXXXY parameters if desired (e.g. pe100A)

I think that my version is a little bit better suited for MontePython integration (given that e.g. I eliminated the dependence on cobaya), but I don't want to step on anyone's toes, given that @mtristram 's version is of course the official. I would be happy to discuss what you think would be the best way moving forward!
(They of course produce the same results and likelihood values)

Cheers!

@mtristram
Copy link
Author

Hi Nils,
That's sounds great !
I do not remember that the cobaya code requires nonlinear=halofit but for the rest, it seems more integrated to MontePython.
Thanks for the work.
Cheers.

@brinckmann
Copy link
Owner

Hi both,

I'm happy with this solution as long as Matthieu agrees, especially since I've already had a couple of people contact me about issues with the Cobaya installation. I was wondering if maybe we can add a note to check Matthieu's repository to see if there has been updates since the last modification of the MontePython likelihood (including the date of that)? More eyeballs on that means we're more likely to notice if we need to update it on our side, although of course Matthieu is always welcome to write us if that's so.

@schoeneberg , would you like to go ahead and add it to the private devel branch? You can also add any other new likelihoods that have been tested (e.g. DESI BAO if you're satisfied it's fine, new WMAP Python 3 wrapper, NPIPE, ground based CMB, etc). I can also do it, but will be quite busy the next three weeks and might not get around to it soon. Then once we have everything there we can put out a new release.

Best,
Thejs

@mtristram
Copy link
Author

Hi both,
Any news on this ?
@schoeneberg does your implementation include the "binned" versions (so-badly-called 'lite' which can be found in branch V4.3 of Hillipop github repo)

Would you be able to put out a new release including those likelihood soon ?

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants